kernel: Remove global tcl.h include
#4809
Merged
+16
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In commit ac988cf we made sure to undefine the CONST/VOID macros left defined by `tcl.h`, but this in turn makes it an issue to include additional Tcl headers later on (see issue YosysHQ#4808). One way out is to avoid a global `tcl.h` include. In the process we drop support for Tcl-enabled MXE builds, which were likely broken anyway due to the additional Tcl APIs used from `tclapi.cc`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the reasons/motivation for this change?
In commit ac988cf we made sure to undefine the CONST/VOID macros left defined by
tcl.h, but this in turn makes it an issue to include additional Tcl headers later on (see issue #4808).One way out is to avoid a global
tcl.hinclude. In the process we drop support for Tcl-enabled MXE builds, which were likely broken anyway due to the additional Tcl APIs used fromtclapi.cc.Fixes #4808 cc @akashlevy